Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implementing infinityModel at public session route #4022

Merged
merged 2 commits into from
Feb 7, 2020
Merged

feat: Implementing infinityModel at public session route #4022

merged 2 commits into from
Feb 7, 2020

Conversation

kushthedude
Copy link
Member

@kushthedude kushthedude commented Feb 7, 2020 •
edited
Loading

Refers #3650
Fixes #4023

  • Sessions were not rendering due to lack of space.
  • Introduced infinity loader and checked the trigger offset, both are working quite well

@auto-label auto-label bot added the feature label Feb 7, 2020
@codecov
Copy link

codecov bot commented Feb 7, 2020 •
edited
Loading

Codecov Report

Merging #4022 into development will increase coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4022      +/-   ##
===============================================
+ Coverage        21.81%   21.93%   +0.11%     
===============================================
  Files              460      460              
  Lines             4726     4733       +7     
===============================================
+ Hits              1031     1038       +7     
  Misses            3695     3695
Impacted Files Coverage Δ
app/routes/public/sessions/list.js 0% <0%> (ø) ⬆️
app/components/public/side-menu.js 0% <0%> (ø) ⬆️
app/components/forms/wizard/basic-details-step.js 25.97% <0%> (+1.31%) ⬆️
app/models/event.js 61.53% <0%> (+7.69%) ⬆️
app/helpers/payment-icon.js 80% <0%> (+80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97fc3c4...88f2e8e. Read the comment docs.

@iamareebjamal
Copy link
Member

Goal is to improve the code as we move on. "It was implemented this way" doesn't really work

@kushthedude
Copy link
Member Author

@iamareebjamal done. Please merge

@kushthedude
Copy link
Member Author

@iamareebjamal Please review now

@kushthedude
Copy link
Member Author

@iamareebjamal Please Review and Merge now!

@kushthedude
Copy link
Member Author

@iamareebjamal Check now

@iamareebjamal iamareebjamal merged commit a8aac00 into fossasia:development Feb 7, 2020
@kushthedude kushthedude deleted the sessi branch February 7, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Month filter not working in session public page
2 participants
@kushthedude @iamareebjamal